On 1/13/23 09:52, Andrea Bolognani wrote:
On Wed, Jan 11, 2023 at 03:05:53PM -0700, Jim Fehlig wrote:
@@ -432,17 +432,30 @@ Summary: Server side daemon and supporting files for libvirt library
# The client side, i.e. shared libs are in a subpackage Requires: libvirt-libs = %{version}-%{release} +Requires: libvirt-daemon-common = %{version}-%{release} Requires: libvirt-daemon-lock = %{version}-%{release} Requires: libvirt-daemon-plugin-lockd = %{version}-%{release} Requires: libvirt-daemon-log = %{version}-%{release} Requires: libvirt-daemon-proxy = %{version}-%{release} +# for modprobe of pci devices +Requires: module-init-tools +%if %{with_numad} +Requires: numad +%endif
I'm not sure why I didn't suggest this in a previous respin, but it would be slightly nicer if you didn't leave these dependencies with the libvirt-daemon and moved them to libvirt-daemon-common along with everything else instead.
This would result in less churn, would not break anything since there's a dependency on libvirt-daemon-common for libvirt-daemon, and you're moving them to the driver subpackages immediately afterwards anyway.
It's a fair point. I'll make the change in V9. Regards, Jim