Re: [libvirt] [PATCH] Move reboot/shutdown flags combination check into QEMU driver

> > The fact that only the guest agent, or ACPI flag can be used > > when requesting reboot/shutdown is merely a limitation of the > > QEMU driver impl at this time. Thus it should not be in > > libvirt.c code > > > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > > --- > > src/libvirt.c | 16 ---------------- > > src/qemu/qemu_driver.c | 16 ++++++++++++++++ > > 2 files changed, 16 insertions(+), 16 deletions(-) > > ACK. Problem. Now our virsh command doesn't have full expression of the possible API usage. You need to modify 'virsh shutdown --mode=...' so that --mode can now take a comma-separated list of modes to combine, rather than only being able to select a single mode, if you want to be able to stress-test the full power of the API.