On 09/02/2013 05:35 AM, Daniel P. Berrange wrote:
On Fri, Aug 30, 2013 at 02:37:20PM -0600, Eric Blake wrote:
I noticed from an ./autobuild.sh run that we were installing a virt-login-shell.exe binary when cross-building for mingw, even though such a binary is necessarily worthless since the code depends on lxc which is a Linux-only concept.
* tools/Makefile.am (conf_DATA, bin_PROGRAMS, dist_man1_MANS): Make virt-login-shell installation conditional.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I'm debating about pushing this under the build-breaker rule.
tools/Makefile.am | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Unfortunately this will now break the libvirt.spec.in if %{with_lxc} is set to 0. Fortunately we don't do that by default for any platforms we support but still nice to fix it
Okay, I'll post a followup patch later today. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org