Re: [libvirt] [PATCH 2/3] Add automated build control script

On Fri, Feb 11, 2011 at 09:09:40PM +0800, Daniel Veillard wrote: > On Fri, Feb 11, 2011 at 12:31:44PM +0000, Daniel P. Berrange wrote: >> Provide a script for performing automated builds >> >> * autobuild.sh: Automated build control script >> * docs/Makefile.am: Remove unused todo.html stuff and allow >> customization of HTML install dir >> * php-libvirt.spec: Fix URLs, source dir name& configure >> invocation. Don't try to install non-existant docs >> * src/Makefile.am: Use $DESTDIR in install rules. Avoid >> rule named 'compile' since that clashes with a automake >> object. Add source files to EXTRA_DIST >> * configure.ac: Add customization of HTML install dir >> --- >> autobuild.sh | 35 +++++++++++++++++++++++++++++++++++ >> configure.ac | 11 +++++++++++ >> docs/Makefile.am | 31 +++++++------------------------ >> php-libvirt.spec | 25 +++++++++---------------- >> src/Makefile.am | 16 ++++++++++------ >> 5 files changed, 72 insertions(+), 46 deletions(-) >> create mode 100755 autobuild.sh > [...] >> diff --git a/php-libvirt.spec b/php-libvirt.spec >> index ca36e7f..b7bc92d 100644 >> --- a/php-libvirt.spec >> +++ b/php-libvirt.spec >> @@ -21,30 +21,23 @@ PHP language bindings for Libvirt API. >> For more details see: http://phplibvirt.cybersales.cz/ http://www.libvirt.org/ http://www.php.net/ >> >> %prep >> -%setup -q -n php-libvirt-%{version} >> -phpize >> +%setup -q -n libvirt-php-%{version} > > just wondering about this, what was phpize supposed to do ? It is kinda like libtoolize or gettextize - something you run to boostrap your project - but with phpize, once you've done it once, there does not appear to be any reason to run it again. Daniel