Michal Privoznik wrote:
On 27.08.2015 23:38, Jim Fehlig wrote:
How does it look with the following squashed in?
diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 8db3aea..9609e06 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -112,9 +112,9 @@ libxlDoMigrateReceive(void *opaque)
/* Remove all listen socks from event handler, and close them. */ for (i = 0; i < nsocks; i++) { - virNetSocketUpdateIOCallback(socks[i], 0); virNetSocketRemoveIOCallback(socks[i]); virNetSocketClose(socks[i]); + virObjectUnref(socks[i]); socks[i] = NULL; } args->nsocks = 0;
Yup, with this piece it looks good. ACK Er, we are currently in a freeze, but after all: a) this is a bugfix, b) this has been sitting on the list quite a while. So I'd say push it.
Thanks. Series pushed. Regards, Jim