Re: [libvirt] [PATCH 6/6] util: Don't report CPU frequency for ARM hosts

13 Dec 2017


      On Wed, 2017-12-13 at 08:45 +0100, Bjoern Walk wrote:
...
...
@@ -563,10 +563,7 @@ virHostCPUGetInfoParseCPUInfo(FILE *cpuinfo,
         } else if (ARCH_IS_PPC(arch)) {
             if (virHostCPUGetInfoParseCPUFrequency(line, "clock", mhz) < 0)
                 goto cleanup;
-        } else if (ARCH_IS_ARM(arch)) {
-            if (virHostCPUGetInfoParseCPUFrequency(line, "BogoMIPS", mhz) < 0)
-                goto cleanup;
-        } else if (ARCH_IS_S390(arch)) {
+        } else if (ARCH_IS_S390(arch) || ARCH_IS_ARM(arch)) {
             /* No reasonable way to obtain CPU frequency */
         } else {
             VIR_WARN("Parser for /proc/cpuinfo needs to be adapted for your architecture");
I'm a bit confused now. If we have a not supported arch, will this
warning not get issued for every line in /proc/cpuinfo? It's the same
for the original code.
Yeah, it would look that way :)

-- 
Andrea Bolognani / Red Hat / Virtualization

    