[libvirt] Fwd: Re: [PATCH] conf: don't format memtune with unlimited values

On 10.12.2013 08:43, Martin Kletzander wrote: > When changing memtune limits to unlimited with AFFECT_CONFIG, the > values in virDomainDef are set to PARAM_UNLIMITED, which causes the > whole <memtune> to be formatted. This can be changed in all drivers, > but it also makes sense to use the default (0) as another value for > "unlimited", since zero memory limit makes no sense. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > > Notes: > This patch efectively completes my previous patch on PARAM_UNLIMITED > [1], but I discovered it just now and found out that the behavior > hasn't changed in between. > > [1] https://www.redhat.com/archives/libvir-list/2013-December/msg00434.html > > src/conf/domain_conf.c | 44 ++++++++++++---------- > .../qemuxml2argv-memtune-unlimited.args | 6 +++ > .../qemuxml2argv-memtune-unlimited.xml | 29 ++++++++++++++ > tests/qemuxml2argvtest.c | 1 + > .../qemuxml2xmlout-memtune-unlimited.xml | 27 +++++++++++++ > tests/qemuxml2xmltest.c | 1 + > 6 files changed, 88 insertions(+), 20 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memtune-unlimited.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memtune-unlimited.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memtune-unlimited.xml ACK