On Tue, Feb 06, 2018 at 14:48:23 +0100, Christian Ehrhardt wrote:
On Tue, Feb 6, 2018 at 2:42 PM, Peter Krempa <pkrempa@redhat.com> wrote:
On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote:
The virt-aa-helper fails to parse the xmls with the memory/cpu hotplug features or user assigned aliases. Set the features in xmlopt->config for the parsing to succeed.
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> --- src/conf/domain_conf.h | 2 ++ src/security/virt-aa-helper.c | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-)
ACK from my side, but I'll wait for a while for the debian/ubuntu guys chiming in.
I had a review and test on v2. This essentially differes by a comment that I also requested - so still ack.
Tested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
I've added the tags and pushed the patch.
P.S. you could say I'm an Ubuntu guy :-)
Definitely :) Sorry for not addressing you directly but I was too lazy to look up the previous conversation.