Re: [libvirt PATCH 0/2] ch: Use payload api

On 10/10/23 23:42, Praveen K Paladugu wrote: > Introduced virCHCapsInitCHVersionCaps to check and cache capabilities of > cloud-hypervisor based on its version. Modified ch driver to use "payload" api > to pass kernel, initramfs and cmdline options to cloud-hypervisor. > > Cloud-hypervisor currently has a single LTS release, v28, that will be supported > until May 24. All versions older than v28 have reached EOL. Can I bump up the > min version of cloud-hypervisor to v28 in ch driver? Our policy is to wait a bit: https://libvirt.org/platforms.html#linux-freebsd-and-macos but I guess given that CH driver is 'best effort' for now, we can drop the support for older releases.

> If I can bump up the min > supported version in ch driver, I can drop a check in this commit related to > supporting serial and console devices in parallel. > > Praveen K Paladugu (2): > ch: use payload api to send kernel details > ch: support serial and console devices in parallel > > src/ch/ch_capabilities.c | 55 ++++++++++++++++++++++++++++++++++++++++ > src/ch/ch_capabilities.h | 34 +++++++++++++++++++++++++ > src/ch/ch_conf.h | 6 +++++ > src/ch/ch_domain.c | 28 ++++++++++++-------- > src/ch/ch_driver.c | 3 +++ > src/ch/ch_monitor.c | 48 +++++++++++++++++++++++++++++++---- > src/ch/ch_monitor.h | 4 ++- > src/ch/ch_process.c | 2 +- > src/ch/meson.build | 2 ++ > 9 files changed, 165 insertions(+), 17 deletions(-) > create mode 100644 src/ch/ch_capabilities.c > create mode 100644 src/ch/ch_capabilities.h > Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; and pushed.

Michal