Re: [libvirt] [PATCH v2 01/12] graphics: don't parse listens if socket attribute is present

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina <phrdina(a)redhat.com&gt; wrote: > If socket attribute is present we start VNC that listens only on that > unix socket. This makes the parser behave the same way as we actually > use the socket attribute. > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > src/conf/domain_conf.c | 8 ++++++++ > .../genericxml2xmloutdata/generic-graphics-vnc-socket-listen.xml | 4 +--- > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 571b7bf..df2258a 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -10721,11 +10721,18 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDefPtr def, > xmlNodePtr save = ctxt->node; > virDomainGraphicsListenDefPtr address = NULL; > char *listenAddr = NULL; > + char *socketPath = NULL; > int nListens; > int ret = -1; > > ctxt->node = node; > > + if (def->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && > + (socketPath = virXMLPropString(node, "socket"))) { > + ret = 0; > + goto error; > + } Even if we keep the <listen> for compatibility purposes, perhaps there is a log/warning to give that it is ignored.