Re: [libvirt] [PATCH 1/2] maint: use common xml quoting style

On 12/07/2011 08:10 PM, Daniel Veillard wrote: But the fact that we _didn't_ have any ' or " in attribute values in all of the conversion is a testament to the fact that we don't want to choose attributes with quoting in the attribute value. One of the improvements, which I already have noticed since I wrote the patch, is that it is easier to search the rng files for a particular macro definition. That is, if you KNOW that a syntax-check rule enforced the style of <define name='blah'>...</define>, it is easier to see <ref name='blah'/> and search for the definition; whereas pre-patch, you could see <ref name='blah'/> but not know whether to search for name='blah' or name="blah" to find the counterpart <define>. Notice that my syntax-check is not documenting anything contrary to the user; that is, no where did I change documentation to suggest to the user that they must prefer '' over "". Rather it is just presenting a consistent interface (since 'virsh dumpxml dom' always outputs name='value', then the web pages that document how to interpret 'virsh dumpxml' output should also use name='value'). We could drop the changes to the tests directory, if you'd like (that is, use just patches 2 and 3 for the ease of rng searching and for the consistent documentation, but leaving the test directory as a way to prove that the quoting style doesn't matter). But if you're dead set against this series, I guess it won't hurt things to drop it (I can continue to do a regex search for name=['"]blah when looking for a <def name='blah'> counterpart in rng, which is particularly hard to type at a shell command line, but oh well). Any other opinions? -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org