On Thu, Nov 04, 2021 at 07:09:07PM +0100, Kashyap Chamarthy wrote:
On Thu, Nov 04, 2021 at 01:22:52PM +0100, Michal Privoznik wrote:
It may come handy to be able to tweak TCG options, in this specific case the size of translation block cache size (tb-size). Since we can expect more knobs to tweak let's put them under common element, like this:
<domain> <features> <tcg> <tb-cache unit='MiB'>128</tb-cache>
Any objection to using underscore (tb_cache), instead of hyphen (tb-cache)? I realize the QEMU option uses the hyphen.
The reason I ask is, as you may know, Python does not allow using assignment operators to its variable names. And when OpenStack Nova adds XML modelling classes for <tcg>, "tb-size" will end up being a variable.
I forgot to mention that this is not an issue. It can be trivially solved in Python to handle the hyphen <-> underscore parsing. Sorry for the noise. -- /kashyap