Re: [libvirt] [PATCH V14 1/5] Introduce virMacAddr typedef
On 05/25/2012 05:56 AM, Stefan Berger wrote:
---
src/util/virmacaddr.h | 2 ++
1 file changed, 2 insertions(+)
Index: libvirt/src/util/virmacaddr.h
===================================================================
--- libvirt.orig/src/util/virmacaddr.h
+++ libvirt/src/util/virmacaddr.h
@@ -30,6 +30,8 @@
# define VIR_MAC_PREFIX_BUFLEN 3
# define VIR_MAC_STRING_BUFLEN VIR_MAC_BUFLEN * 3
Not your fault, but this line is broken. It should be:
# define VIR_MAC_STRING_BUFLEN (VIR_MAC_BUFLEN * 3)
+typedef unsigned char virMacAddr[VIR_MAC_BUFLEN];
+
int virMacAddrCompare(const char *mac1, const char *mac2);
void virMacAddrFormat(const unsigned char *addr,
char *str);
Simple enough. ACK with the additional fix.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)