Re: [libvirt] [PATCH v1 11/31] conf: Format and parse NVMe type disk

On Thu, Jul 11, 2019 at 18:12:16 +0200, Michal Privoznik wrote: > On 7/11/19 6:05 PM, Peter Krempa wrote: > > On Thu, Jul 11, 2019 at 17:53:58 +0200, Michal Privoznik wrote: > > > To simplify implementation, some restrictions are added. For > > > instance, an NVMe disk can't go to any bus but virtio and has to > > > be type of 'disk' and can't have startupPolicy set. > > > > > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > > > ---

Yes it certainly will be possible with blockdev. Also you have such a file in the backing chain which gets detected from the file metadata on the disk, so such a check will probably need to be duplicated also when starting the VM (the validate callback function may be better match). > > > > > Also this seems all to belong to the qemu specific post parse callback. > > Possibly. But since other drivers would still use virNVMeDevice module I'm > adding later in this series, and since the module is build on these > assumptions I figured the best place to check for them is in driver agnostic > callback. Fair enough.