On 07/08/14 00:44, Eric Blake wrote:
On 07/04/2014 05:22 AM, Peter Krempa wrote:
Now that we are able to select images from the backing chain via indexed access we should also convert possible network sources to qemu-compatible strings before passing them to qemu. --- src/qemu/qemu_driver.c | 45 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 41 insertions(+), 4 deletions(-)
@@ -15027,6 +15029,13 @@ qemuDomainBlockJobImpl(virDomainObjPtr vm, goto cleanup; }
+ if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE && !base) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("flag VIR_DOMAIN_BLOCK_REBASE_RELATIVE is valid only " + " with non-null base "));
double space and trailing space in the resulting error string.
Should we hoist this check into libvirt.c, or is there a chance that some other driver may support the combination? But we can make that decision in a followup patch if we decide to do it.
Well looks like it won't be ever supported so we might move it to the lib. I'll post a followup to provide a place for the discussion.
ACK with the spacing fixed.
I've fixed the nits pointed out and pushed the series. Thanks. Peter