Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

On Mon, Jun 26, 2017 at 10:10:55AM -0400, Cole Robinson wrote: > On 06/24/2017 10:07 PM, Andrea Bolognani wrote: >> On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: >>> At this point I'm a little confused about how to proceed here. Would >>> you like further evidence of an environment that reproduces the issue >>> with console and the isa bus, with additional logic added to this >>> patch to fix that, or should we get this patch merged and fix the >>> other issue separately? >> >> We can merge the patch without further changes to it, as >> it fixes part of the issues that prevent the feature to work. >> >> Actually, I just added >> >> Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; >> >> and pushed it :) > > It may fix part of the issue but it likely breaks all existing aarch64 -M virt > libvirt VMs. My VM created by virt-manager has: > > <serial type='pty'> > <target port='0'/> > </serial> > <console type='pty'> > <target type='serial' port='0'/> > </console> > > And after this patch fails with: > > error: Failed to start domain fedora25-aarch64 > error: internal error: process exited while connecting to monitor: > 2017-06-26T13:55:34.726293Z qemu-system-aarch64: -chardev pty,id=charserial0: > char device redirected to /dev/pts/5 (label charserial0) > 2017-06-26T13:55:34.782121Z qemu-system-aarch64: -device > isa-serial,chardev=charserial0,id=serial0: No 'ISA' bus found for device > 'isa-serial' > > There's a few things going on here: > > - Internally libvirt thinks that by default <serial> is isa-serial > - For arm qemu though it's actually a pl011. This is a platform device and as > such there isn't any current way to use -chardev with it AFAIK. There is, -chardev pty,id=chardev0,logfile=/my/log/file \ -serial chardev:chardev0