Re: [libvirt] [PATCH v2 36/36] conf: switch over to use network port APIs for virt drivers
On 2/27/19 11:29 AM, Daniel P. Berrangé wrote:
Change the domain conf so invoke the new network port public APIs
instead
of the network callbacks.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/conf/domain_conf.c | 262 ++++++++++++++++++++++++------------
src/conf/domain_conf.h | 26 ----
src/network/bridge_driver.c | 200 ---------------------------
3 files changed, 178 insertions(+), 310 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 61987e7f51..2031868101 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
[...]
-
-void
-virDomainNetSetDeviceImpl(virDomainNetAllocateActualDeviceImpl allocate,
- virDomainNetNotifyActualDeviceImpl notify,
- virDomainNetReleaseActualDeviceImpl release,
- virDomainNetBandwidthUpdateImpl bandwidthUpdate)
-{
- netAllocate = allocate;
- netNotify = notify;
- netRelease = release;
- netBandwidthUpdate = bandwidthUpdate;
-}
As a preliminary step in testing and reviewing this, I ran
git rebase -i -x "make -j8 syntax-check && make -j8 check" master
on a branch where I'd git am'ed all the patches. The only error was at
this last patch, where make check failed because you've removed the
implementation of virDomainNetSetDeviceImpl(), but forgot to take it out
of libvirt_private.syms.
I'll come back for a more detailed review later...