Re: [libvirt] [PATCH libvirt master] interface type: add udp socket support

On 8/10/15 11:06 AM, Ján Tomko wrote: >> >> Signed-off-by: Jonathan Toppins <jtoppins(a)cumulusnetworks.com&gt; >> --- >> docs/formatdomain.html.in | 17 ++++++++++++ >> src/conf/domain_conf.c | 56 +++++++++++++++++++++++++++++++++++++--- >> src/conf/domain_conf.h | 3 +++ >> src/conf/netdev_bandwidth_conf.h | 1 + >> src/libxl/libxl_conf.c | 1 + >> src/lxc/lxc_controller.c | 1 + >> src/lxc/lxc_process.c | 1 + >> src/qemu/qemu_command.c | 12 +++++++++ >> src/qemu/qemu_hotplug.c | 1 + >> src/qemu/qemu_interface.c | 2 ++ >> src/uml/uml_conf.c | 5 ++++ >> src/xenconfig/xen_sxpr.c | 1 + >> tools/virsh-domain.c | 1 + >> 13 files changed, 99 insertions(+), 3 deletions(-) > > Missing test cases for tests/qemuxml2argvtest.c and > tests/qemuxml2xmltest.c. Didn't know about the unit test area, would be happy to add some unit tests. Is there some text document describing how one runs these tests and needs to set things up or should I just read a good example?

> >> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in >> index c0a265a..95f7f5d 100644 >> --- a/docs/formatdomain.html.in >> +++ b/docs/formatdomain.html.in >> @@ -4165,6 +4165,23 @@ >> &lt;/devices&gt; >> ...</pre> >> >> + <h5><a name="elementsNICSUDP">UDP unicast tunnel</a></h5> >> + >> + <p> >> + A UDP unicast architecture provides a virtual network which enables >> + connections between Qemu instances using Qemu's UDP infrastructure.</p> >> + > > It would be nice to document what the addresses mean, and mention that > this is supported <span class="since">Since 1.2.19</span>. ack, do I need to add it after the description paragraph (<p></p>)?