Re: [libvirt] [PATCH] addrToString: give better error message
2010/4/20 Eric Blake <eblake(a)redhat.com>:
The user probably doesn't care what the gai error numbers are,
as
much as what the failed conversion IP address was.
* src/remote/remote_driver.c (addrToString): Mention which address
could not be converted.
* daemon/remote.c (addrToString): Likewise.
---
In response to
https://www.redhat.com/archives/libvir-list/2010-April/msg00219.html
daemon/remote.c | 24 +++++++++++++++++-------
src/remote/remote_driver.c | 22 ++++++++++++++++------
2 files changed, 33 insertions(+), 13 deletions(-)
@@ -3169,21 +3170,30 @@ remoteDispatchAuthList (struct qemud_server
*server,
#if HAVE_SASL
/*
- * NB, keep in sync with similar method in src/remote_internal.c
+ * NB, keep in sync with similar method in src/remote/remote_driver.c
Nice cleanup.
*/
static char *addrToString(remote_error *rerr,
- struct sockaddr_storage *sa, socklen_t salen) {
+ struct sockaddr_storage *ss, socklen_t salen) {
char host[1024], port[20];
Maybe change this to
char host[NI_MAXHOST], port[NI_MAXSERV];
like in addrToString in src/remote/remote_driver.c.
ACK
Matthias