On 3/13/19 11:51 AM, Andrea Bolognani wrote:
Apparently this was necessary in the past because old versions of autoconf/automake didn't make them available, but these days all of the platforms we target include recent enough autotools - as evidenced by the fact that, for example, we already use abs_top_srcdir in tools/ despite the fact that tools/Makefile.am is missing the same boilerplate.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/Makefile.am | 6 ------ tests/Makefile.am | 6 ------ 2 files changed, 12 deletions(-)
Commit 9aef4d96 states that it was automake from RHEL 5 that caused the grief; as we no longer support that platform, we no longer have to maintain the back-compat hacks. The next back-compat hack to get rid of: we should stop using INCLUDES in Makefile.am, and instead spell it CPPFLAGS. INCLUDES was necessary for automake 1.9.6 (see commit 6ae3052c), but modern automake says it is outdated. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org