Re: [libvirt] [PATCH] virsh: add --start option to the define command

On 02/18/13 06:11, Doug Goldstein wrote: > > On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther <agx(a)sigxcpu.org&gt; wrote: >> >> On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: >>> >>> On 01/08/2013 02:36 PM, Doug Goldstein wrote: >>>> >>>> I often find myself doing virsh "define blah.xml; start blah". I >>>> figured >>>> adding this would be a easier^Hlazier way to do it. >>>> --- >>>> tools/virsh-domain.c | 20 ++++++++++++++++++-- >>>> 1 files changed, 18 insertions(+), 2 deletions(-) >>> >>> > I'd like to still add "virsh define --start" in the end. Possibly when > --start is passed, virsh would actually call virDomainCreateXML(). My > feeling is that virsh started out really demoing the API but its > really a fundamental user tool now and we should strive to make it > friendly to use. I think that the original version of your patch is usable although it's lacking documentation in the man page. If you mind reposting it with that added it might be a intermediate road until somebody will be motivated enough to add the flag for virDomainCreateXML. Peter