Re: [libvirt PATCH v2 0/2] rST-ify and rewrite a couple of block-layer docs
On Tue, May 11, 2021 at 09:54:28AM +0200, Michal Prívozník wrote:
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
> I don't think the Debian "sid" failure is related to my patch:
>
> https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
>
> Changes in v2:
>
> - Mention backupBegin() [Peter]
> - Add examples of push-mode backup using backupBegin() [Peter, Kashyap]
> - Use existing rST conventions to make `rst2html5` happy [Michal]
> - Update meson.build [Michal]
> - Use .contents:: [Michal]
> - Paragraph alignment [Michal]
>
> Kashyap Chamarthy (2):
> docs: kbase: Add a doc on live full disk backup
> docs: kbase: Add a doc on merging disk image chains
>
> docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++
> docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++
> docs/kbase/meson.build | 2 +
> 3 files changed, 388 insertions(+)
> create mode 100644 docs/kbase/live_full_disk_backup.rst
> create mode 100644 docs/kbase/merging_disk_image_chains.rst
>
Patches look good and I'm inclined to merge them. Thank you for
reworking v1 per our reviews. However, what I completely missed in my
review of v1 is to add links from docs/kbase/index.rst to new pages
you're introducing. I can fix that before push if you reply with a diff
that would do just that.
Duh, I was thinking "I missed something but not sure what". Thanks for
the review and fixing it up. Here we go, the index.rst `diff`:
$> git diff docs/kbase/index.rst
diff --git a/docs/kbase/index.rst b/docs/kbase/index.rst
index 532804fe05..d483ca94de 100644
--- a/docs/kbase/index.rst
+++ b/docs/kbase/index.rst
@@ -37,6 +37,12 @@ Usage
`Launch security <launch_security_sev.html>`__
Securely launching VMs with AMD SEV
+`Live full disk backup <live_full_disk_backup.html>`__
+ A walkthrough of how to take effective live full disk backups.
+
+`Merging disk image chains <merging_disk_image_chains.html>`__
+ Ways to reduce or consolidate disk image chains.
+
`KVM real time <kvm-realtime.html>`__
Run real time workloads in guests on a KVM hypervisor
--
/kashyap