14 Feb
2011
14 Feb
'11
11:40 p.m.
On 02/14/2011 03:06 PM, Laine Stump wrote:
On 02/14/2011 03:02 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=676563
Regression introduced in commit 2211518.
* src/qemu/qemu_capabilities.c (qemuCapsProbeMachineTypes): Allow non-zero exit status. - if (virCommandRun(cmd, NULL)< 0) + /* Ignore failure from older qemu that did not understand '-M ?'. */ + if (virCommandRun(cmd,&status)< 0) goto cleanup;
if (qemuCapsParseMachineTypesStr(output, machines, nmachines)< 0)
ACK. The older code printed a warning on non-zero exit, but didn't fail, so this is proper.
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org