Re: [libvirt] [PATCH] Be more clever and verbose about localization-initialization.
Hi all,
@Eric, the problem is that there is no "Why" in the error message.
@DanielW, you had the exact oposite problem of myself. I had correct language-settings for
the service, but when
I tried to start libvirtd from the user directly, it used the wrong LC_MESSAGE that it
inherited from the ssh connection. ;-)
So specifically for all those people that try to ssh from a localized desktop into a
localization-free server-box
(which is very common I suppose), I think the "fallback to LC_ALL=C" approach
with some warning message to
stderr would be the preferable solution.
Cheers,
Andreas
________________________________________
Von: Daniel J Walsh [dwalsh(a)redhat.com]
Gesendet: Montag, 4. November 2013 22:27
An: Eric Blake; Fuchs, Andreas; Daniel P. Berrange
Cc: libvir-list(a)redhat.com
Betreff: Re: [libvirt] [PATCH] Be more clever and verbose about
localization-initialization.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/04/2013 04:11 PM, Eric Blake wrote:
On 10/08/2013 01:35 AM, Fuchs, Andreas wrote:
> I'd argue _for_ starting up libvirtd in case of errorous LC_* info. Since
> it is not a user-facing application but a system daemon, I think the
> impact of wrong language is small, but the benefit of having the daemon
> starting realiably is quite high.
I still think that someone setting up the wrong language is a case of admin
error, and that failing to start is appropriate. But this issue just
caused a second bugzilla today:
https://bugzilla.redhat.com/show_bug.cgi?id=1026514
so you aren't the only one to have hit the issue. However, in reading that
bug, Dan Walsh (now cc'd) apparently didn't even find the stderr message
that tried to alert him to why libvirtd was exiting early. Whether or not
we apply your patch, there's the meta-issue that if libvirtd under systemd
outputs an error to its stderr, where does that message go and how does an
admin find out why libvirtd exited early?
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: Starting
Virtualization daemon...
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: Started
Virtualization daemon.
Oct 14 17:43:48 redsox.boston.devel.redhat.com libvirtd[646]:
/usr/sbin/libvirtd: initialization failed
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: libvirtd.service:
main process exited, code=exited, status=1/FAILURE
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: Unit
libvirtd.service entered failed state.
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: libvirtd.service
holdoff time over, scheduling restart.
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: Stopping
Virtualization daemon...
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: Starting
Virtualization daemon...
Oct 14 17:43:48 redsox.boston.devel.redhat.com systemd[1]: Started
Virtualization daemon.
This is what I was getting. libvirt initialization failed.
Of course when I ran it myself it worked fine. Since the user session had the
correct LANG set.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlJ4EUYACgkQrlYvE4MpobOpPQCfb6oN3Vxw48ccyG2eVBwV3Xks
G5sAoIftVHsM1NSq705OB0H+hCpeTFuJ
=T8QH
-----END PGP SIGNATURE-----