On Tue, May 28, 2019 at 01:51:06PM +0200, Andrea Bolognani wrote:
On Tue, 2019-05-28 at 13:34 +0200, Daniel Veillard wrote:
On Tue, May 28, 2019 at 01:14:19PM +0200, Ján Tomko wrote:
This reverts commit 8a1179831b5edc0a3590489eda693914fc0ff94f.
It bumped the version prematurely, before the EOL of Fedora 28.
Yeah, that was my bad :( I'll be more careful about releases having actually hit EOL before dropping support for them in the future.
I'd say for Fedora's case, we could happily wait even for half a year more or so - by dropping it here we did not really gain anything - all the libraries needed for libvirt to work on F28 are still way newer than stuff from the long-term supported distros. Jano
Morover, this arbitrary bump did not let us perform any cleanups in the specfile.
Right, that said I just tagged before this commit can be in. I just won't make the binary rpms, after some discussion that's probably not useful in general.
I agree we have no use for binary RPMs, especially when things like
https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/virt-preview/
exist.
I would ACK but F28 will be dropped from support end of the week, so maybe we don't want to flip/flop that at this point,
Let's just leave it as is, and just make sure we don't repeat the same mistake in the future.