On Thu, Oct 25, 2018 at 09:44:01PM +0100, Daniel P. Berrangé wrote:
On Sat, Oct 20, 2018 at 05:19:47PM +0300, Roman Bolshakov wrote:
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com> --- src/qemu/qemu_capabilities.c | 1 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e228f52ec0..65cf5b5c03 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -508,6 +508,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, /* 315 */ "vfio-pci.display", "blockdev", + "hvf", );
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 934620ed31..e61f1e78a9 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -492,6 +492,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */ /* 315 */ QEMU_CAPS_VFIO_PCI_DISPLAY, /* -device vfio-pci.display */ QEMU_CAPS_BLOCKDEV, /* -blockdev and blockdev-add are supported */ + QEMU_CAPS_HVF, /* Whether Hypervisor.framework is available */
QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags;
I expect this addition would have broken the 'make check' tests for the capabilities, so they likely need an update.
Hi Daniel, Indeed, that's true. It broke all but 4 capabilities tests on PATCH 11 (https://www.redhat.com/archives/libvir-list/2018-October/msg01098.html) including the ones I didn't expect, like tests for s390x. I wonder what could be the reason? I have looked at the recent additions of capabilities. Most of them just add a flag for related platform and that's it. That doesn't work for me though. May be that's because I should add CPU definitions for hvf domain type? Still, that doesn't explain how hvf cpu appeared in actual output of s390x capabilities test: <hostCPU type='hvf' model='z14-base' migratability='no'> May be a cross-product of all domain types and all CPUs is checked. I've attached test log file. The code can be checked out of hvf-domain branch in the repo: https://github.com/roolebo/libvirt.git -- Best regards, Roman