On Wed, Feb 04, 2026 at 22:29:16 +0300, Dmitry Lopatin wrote:
Add missing return value checks to fix the following issues reported by the static analyzer:
- virDriverLoadModule() call when loading the storage driver (line 908) was not checked, while there are examples with return code check throughout the code.
Your patch is missing declaration that it conforms to the Developer Certificate of Origin, which is required for all our submissions: https://www.libvirt.org/hacking.html#developer-certificate-of-origin Although now I see that your v1 had this.
--- src/security/virt-aa-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index f4ec6b7826..2de1b31b5a 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -892,7 +892,8 @@ get_files(vahControl * ctl)
/* load the storage driver so that backing store can be accessed */ #ifdef WITH_STORAGE - virDriverLoadModule("storage", "storageRegister", false); + if (virDriverLoadModule("storage", "storageRegister", false) < 0) + goto cleanup;("storage", "storageRegister", false);
^^^^^^^^^^ This looks very broken
#endif
for (i = 0; i < ctl->def->ndisks; i++) { -- 2.34.1