Re: [libvirt] [PATCH 0/4] Fix the domain capabilities wrt maxvcpus
On 06/22/2016 08:55 PM, Andrea Bolognani wrote:
On Wed, 2016-06-15 at 09:54 +0000, Shivaprasad G Bhat wrote:
> This series addresses the comments to my patch in
> http://www.redhat.com/archives/libvir-list/2016-May/msg00218.html
>
> The v2 got quite a lot of criticism to not to change the virConnectGetMaxVCPUS()
> instead document to use the virConnectGetDomainCapabilities().
> The virConnectGetDomainCapabilities() is extended to check for the host limits
> and the NR_CPUs are also returned. I am planning to follow up this series
> with possible fixes to maxvcpus command once this merged.
Sorry for being late in reviewing this series.
If you can post a v2 addressing my comments in the next
couple of days, there's still time for it to be merged
in time for 2.0.0 - the freeze is on Sunday.
Thanks Andrea. As discussed with you
on IRC, I am dropping my changes
for "suggested" cpus in
the next version and follow it up separately, so just the bug fix is
easier for the build.
Please note that it doesn't apply cleanly on top of
current master, but the conflict is easy enough to fix.
--
Andrea Bolognani
Software Engineer - Virtualization Team