Hi John, For some reason I don't see these errors in my environment, I would appreciate it if you could fix them before merging. Thank you!! -----Original Message----- From: John Ferlan [mailto:jferlan@redhat.com] Sent: Wednesday, August 23, 2017 8:44 PM To: Edan David <edand@mellanox.com>; libvir-list@redhat.com Subject: Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities On 08/21/2017 05:19 AM, Edan David wrote:
Adding functionality to libvirt that will allow querying the interface for the availability of switchdev Offloading NIC capabilities. The switchdev mode was introduced in kernel 4.8, the iproute2-devlink command to retrieve the swtichdev NIC feature, Command example: devlink dev eswitch show pci/0000:03:00.0 This feature is needed for Openstack so we can do a scheduling decision if the NIC is in Hardware Offload (switchdev) or regular SR-IOV (legacy) mode. And select the appropriate hypervisors with the requested capability see [1].
[1] - https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fspe cs.openstack.org%2Fopenstack%2Fnova-specs%2Fspecs%2Fpike%2Fapproved%2F enable-sriov-nic-features.html&data=02%7C01%7Cedand%40mellanox.com%7C7 58a68d1796c435a8af108d4ea4e889b%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0 %7C0%7C636391070397000461&sdata=dbe8Z6P71ZEqC3u46YB1hkmmm8pQgYpWjjVxvB fu5Ko%3D&reserved=0 --- configure.ac | 13 ++ docs/formatnode.html.in | 1 + src/util/virnetdev.c | 187 +++++++++++++++++++++- src/util/virnetdev.h | 1 + tests/nodedevschemadata/net_00_13_02_b9_f9_d3.xml | 1 + tests/nodedevschemadata/net_00_15_58_2f_e9_55.xml | 1 + 6 files changed, 203 insertions(+), 1 deletion(-)
Again - make check syntax-check had a failure because properly indent "#if" to be "# if" (also "# else" and "# endif") I can fix that easily before pushing though. Reviewed-by: John Ferlan <jferlan@redhat.com> I'll wait a day before pushing - just in case laine comes back from chasing the eclipse and has a comment to make... Tks - John