Re: [libvirt PATCH 2/2] ci: Call meson consistently
On Mon, Mar 29, 2021 at 10:17:51AM +0200, Andrea Bolognani wrote:
On Fri, 2021-03-26 at 18:55 +0100, Pavel Hrdina wrote:
> On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote:
> > Even though you didn't spell that out explicitly, I assume you're
> > okay with me pushing this series during the freeze?
>
> I know it's trivial and most likely will not affect the release at all
> but my understanding of freeze is that we try to stabilize the build
> by fixing bugs or any issues that would prevent us to deliver the final
> release.
>
> To me that sounds like reasonable definition that we should try to
> follow and in my mind creates a clear decision process if something
> should/can be pushed during freeze.
>
> Based on that definition I would say that these patches does not
> qualify and can easily wait once the release is done.
Different people seem to have different understanding of what does
and does not qualify for merging during the freeze: in the past, I've
argued for the same interpretation that you're offering right now,
only to receive significant pushback ¯\_(ツ)_/¯
That said, I agree with both you and Erik that there is basically no
reason for this *not* to wait until 7.2.0 is out, so I'll just play
it safe and do just that :)
The wording I remember was that during freeze we can push patches that
fix bugs, alter documentation, or have been already posted (with an
extra caution). There was no CI back then. Maybe we need to adjust
that for the future somehow, but given the fact that this was not
written down anywhere I do not know how to do that officially.
--
Andrea Bolognani / Red Hat / Virtualization
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)