On Fri, Apr 10, 2015 at 12:41:12 +0200, Erik Skultety wrote:
This patch adds checks for empty bitmaps right after the calls of virBitmapParse. These only include spots where set API's are called and where domain's XML is parsed.
https://bugzilla.redhat.com/show_bug.cgi?id=1210545 --- src/conf/domain_conf.c | 35 +++++++++++++++++++++++++++++++---- src/conf/numa_conf.c | 23 +++++++++++++++++++---- src/qemu/qemu_driver.c | 5 +++-- src/xenconfig/xen_sxpr.c | 7 +++++++ 4 files changed, 60 insertions(+), 10 deletions(-)
I've "git grep"'d a few uses of this function and found a few places that would also need a chceck. Few examples are the XML parser for networks, the use in qemuProcessStart() to parse the automatic placemenet and so on .. The rest looks good though. Peter