On 04/05/2013 10:53 AM, Eric Blake wrote:
On 04/05/2013 10:50 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Validate that translations between different keycode sets are functioning.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- tests/virkeycodetest.c | 107 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 tests/virkeycodetest.c
Never hurts to add tests :)
But you might want to touch up .gitignore so future users don't commit a binary into .git by accident when doing 'git add -a'.
+static int +mymain(void) +{ + int ret = 0; + + if (virtTestRun("Keycode mapping ", 1, testKeycodeMapping, NULL) < 0) + ret = -1; + if (virtTestRun("Keycode strings ", 1, testKeycodeStrings, NULL) < 0) + ret = -1; + + return ret==0 ? EXIT_SUCCESS : EXIT_FAILURE;
Spaces around ==.
ACK.
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org