Re: [libvirt] [PATCH V6] support offline migration

You either need to take care of migrating storage if the user does 'virsh migrate [whatever-we-decide-for-offline] --copy-storage-*', or else explicitly reject attempts to migrate storage in parallel with an offline migration.

> @@ -439,6 +441,11 @@ qemuMigrationCookieXMLFormat(struct qemud_driver *driver, > virBufferAdjustIndent(buf, -2); > } > > + if (mig->flags & QEMU_MIGRATION_COOKIE_OFFLINE) { > + virBufferAsprintf(buf, " <offline>\n"); > + virBufferAddLit(buf, " </offline>\n"); Collapse these two lines into the simpler one-liner: virBufferAddLit(buf, " <offline/>\n");