Re: [libvirt] [PATCH] tests: securityselinuxlabel: Add QEMU_CAPS_VNC to fake qemuCaps
On 12/17/19 4:04 AM, Peter Krempa wrote:
In commit 45270337f057f26ce484f6e forgot to make sure that tests
pass.
Add the missing capability to fix the test.
Thanks for the fixing this. FWIW I tested every commit individually,
multiple times over as I was poking at this series over a few days. At
one point I was hitting securityselinuxlabeltest failures, but when I
would run the test directly it succeeded. Then I rebased to master and
the test failure went away and I couldn't reproduce. I pushed the series
to another machine and tests passed there too.
There must be something that makes the test flakey, or ordering
dependent maybe? Daniel obviously was running at least some portion of
the test suite, considering most patches in the series had to adjust the
test suite to match.
- Cole