Re: [libvirt] [PATCH 3/3] qemu: command: explicitly error for non-x86 default CPU
On 07/21/2017 10:25 AM, Ján Tomko wrote:
On Fri, Jul 14, 2017 at 07:43:06PM -0400, Cole Robinson wrote:
> The code only currently handles writing an x86 default -cpu
> argument, and doesn't know anything about other architectures.
> Let's make this explicit rather than leaving ex. qemu ppc64 to
> throw an error about -cpu qemu64
>
> Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
> ---
> src/qemu/qemu_command.c | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
ACK
Jan
Thanks, I pushed patch 2 + 3 now which you reviewed, patch 1 was independent
and has some comments.
- Cole