On 9/19/19 5:01 AM, Xu Yandong wrote:
In function virDomainDeviceDefParse, we shoud use virDomainDeviceDefFree free data structure avoid potential memory leak.
Signed-off-by: Xu Yandong <xuyandong2@huawei.com> --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 848c831330..8fb9480827 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16504,7 +16504,8 @@ virDomainDeviceDefParse(const char *xmlStr, return dev;
error: - VIR_FREE(dev); + virDomainDeviceDefFree(dev); + dev = NULL;
You don't need the 'dev = NULL' after virDomainDeviceDefFree(dev). This function will end up calling VIR_FREE(dev) in the end, which will make dev = NULL. WIthout the extra dev = NULL assignment: Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
goto cleanup; }