Re: [libvirt] [PATCH] utils: storage: Add copying of PR definition to virStorageSource
On Tue, Jul 17, 2018 at 04:03:49PM +0200, Peter Krempa wrote:
Despite the warning that virStorageSourceCopy needs to be populated
on
additions to the structure commit 687730540e4 neglected to implement the
copy function.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/util/virstoragefile.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Also not copied:
bool authInherited;
bool encryptionInherited;
bool nocow;
bool sparse;
and all the properties from the last section (starting at 'iomode')
It would be nice to mention the properties that do not need to be copied
and copy them in the same order they are declared in.
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)