Re: [libvirt] [PATCH] qemu: Fix migration with dname
On Tue, Oct 04, 2011 at 14:03:34 +0100, Daniel P. Berrange wrote:
On Tue, Oct 04, 2011 at 12:06:10PM +0200, Jiri Denemark wrote:
> Destination libvirtd remembers the original name in the prepare phase
> and clears it in the finish phase. The original name is used when
> comparing domain name in migration cookie.
What is the actual error we get ? Is it that the 'Confirm' method
raises an error "Incoming cookie data had unexpected name" ?
It's actually the Prepare method that fails but the error is the same
(obviously since it comes from EatCookie).
> Notes:
> Originally, I wanted to transfer the new name in migration cookie but
> that appeared to be much more complicated and it would require adding
> new Confirm API since the current version does not have 'dname'
> parameter.
IIUC, you are trying to fix this, by making sure that the 'Finish'
method encodes the original name in the cookie, not the new name ?
Yes, although the complete picture is that incoming (from the POV of
destination libvirtd) cookie is checked against the original name instead of
the new one and cookies generated by destination libvirtd contain the original
name. It applies to Prepare as well as Finish.
ACK, if my two questions here are correct
Mostly correct so I take it as ACK :-)
Jirka