Re: [libvirt] [PATCH] Fix bug in storage driver accessing wrong private data
On Wed, Dec 09, 2009 at 09:47:44AM +0000, Richard W.M. Jones wrote:
On Wed, Dec 09, 2009 at 09:39:17AM +0000, Daniel P. Berrange wrote:
> * src/storage/storage_driver.c: Fix IsPersistent() and IsActivE()
> methods on storage pools to use 'storagePrivateData' instead
> of 'privateData'. Also fix naming convention of objects
Looks correct - ACK. This fixes the crash in libvirtd?
Yes, it may or may not crash depending mostly on luck. It didn't crash
for me, but it certainly wouldn't give the answer you'd want :-)
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|