On Mon, 2009-07-27 at 22:19 +0100, Daniel P. Berrange wrote:
On Wed, Jul 22, 2009 at 10:57:29PM +0100, Mark McLoughlin wrote:
Hey, So, here are the patches needed to complete the QEMU NIC hotplug work by supporting network and bridge backed interfaces.
We support this by passing a tap file descriptor to qemu over the monitor socket using SCM_RIGHTS.
The monitor commands required for this (getfd and closefd) are queued up in Anthony's queue and should be in qemu-0.11-rc1 which is due to be released very soon:
http://repo.or.cz/w/qemu/aliguori-queue.git?a=commitdiff;h=4edd6c2645 http://repo.or.cz/w/qemu/aliguori-queue.git?a=commitdiff;h=f4069061e3
Note: I just remembered I'm not handling missing support for these commands very well. I'll make it handle an 'unknown command' reply gracefully by failing the attach tommorrow.
ACK to this patch series since its almost certainly going into QEMU upstream any minute. It doesn't have any public API impact, so worst case we later change / remove it.
Thanks, it's upstream now: http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=c1d6eed7e8 as is the machine type aliases: http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=9574758134 This is on the 0.12 branch, but I've asked for them to be pulled into the stable-0.11 branch ... we'll see. Cheers, Mark.