Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

On 08/01/2018 07:57 AM, Bjoern Walk wrote: > And here's the fix for the viriscsitest on big-endian machine like > Daniel suggested. > From d59b254294a90c5a9ca0fb6ad29465cd0950bb61 Mon Sep 17 00:00:00 2001 > From: Bjoern Walk&lt;bwalk(a)linux.ibm.com&gt; > Date: Wed, 1 Aug 2018 14:48:47 +0200 > Subject: [PATCH] util: virrandom: make virRandomBits endian-safe > > Make the generation of random bits in virRandomBits independent of the > endianness of the running architecture. > > This also solves problems with the mocked random byte generation on > big-endian machines. > > Suggested-by: Daniel P. Berrangé&lt;berrange(a)redhat.com&gt; > Signed-off-by: Bjoern Walk&lt;bwalk(a)linux.ibm.com&gt; > --- > src/util/virrandom.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > - ret &= (1ULL << nbits) - 1; > - return ret; > + return virReadBufInt64LE(ret) & ((1ULL << nbits) - 1); Needs to be rebased on top of the fix that (1ULL << 64) is not defined.