Re: [libvirt] [PATCH] qemu: Need to check for machine.os when using ADDRESS_TYPE_CCW
On Wed, 2015-09-02 at 15:47 +0200, Ján Tomko wrote:
> case VIR_DOMAIN_DISK_BUS_VIRTIO:
> if (disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)
> {
> + if (!STREQLEN(def->os.machine, "s390-ccw", 8)) {
Maybe we need a 'qemuDomainMachineIsS390CCW' helper?
I'd also use STRPREFIX() instead of STREQLEN().
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team