On Thu, Sep 24, 2009 at 11:39:08PM +0200, Matthias Bolte wrote:
2009/9/24 Daniel P. Berrange <berrange(a)redhat.com>:
>
> Outside the scope of your patches, I think it would be
> worth adding a 'name' attribute to all devices in the
> libvirt XML as a standardized unique identifier. We
> already have to keep track of a 'name' internally for
> NIC hotplug with QEMU, and with QEMU's qdev work we're
> going to end up having to track a 'name' for pretty much
> all devices. Thus we might as well expose it in the XML
>
Would this device name be read-only, or would it be editable/writable
by the user (e.g. through virsh edit)? If it should be read-only, I
see no problem supporting device names in the ESX driver. But If it
should be editable/writable it may be a problem to implement this for
the ESX driver, as I'm currently not aware of any sensible way to
store such an custom device name in a persistent manner on an ESX
server.
Latest QEMU allows the name to be choosen by the application arbitrarily,
but older QEMU auto-assigned names itself. I don't see any compelling
reason to make the names editable by applications, so it is probably
sufficient to say they'll be read-only / output-only attributes in the
XML assigned by the hypervisor driver as required.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://ovirt.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|