On 02/11/2012 08:18 AM, Eric Blake wrote:
On 02/10/2012 03:17 AM, Guannan Ren wrote:
*libvirt_virDomainBlockStatsFlags *libvirt_virDomainGetSchedulerParameters *libvirt_virDomainGetSchedulerParametersFlags *libvirt_virDomainSetSchedulerParameters *libvirt_virDomainSetSchedulerParametersFlags *libvirt_virDomainSetBlkioParameters *libvirt_virDomainGetBlkioParameters *libvirt_virDomainSetMemoryParameters *libvirt_virDomainGetMemoryParameters *libvirt_virDomainSetBlockIoTune *libvirt_virDomainGetBlockIoTune --- python/libvirt-override-api.xml | 12 +- python/libvirt-override.c | 885 +++++++++++++-------------------------- 2 files changed, 295 insertions(+), 602 deletions(-)
Looks like your patch overlaps with Alex's patch.
static PyObject * libvirt_virDomainSetSchedulerParameters(PyObject *self ATTRIBUTE_UNUSED, - PyObject *args) { + PyObject *args) +{ virDomainPtr domain; PyObject *pyobj_domain, *info; + PyObject *ret = NULL; char *c_retval; int i_retval; - int nparams, i; - virTypedParameterPtr params; + int nparams = 0, size = 0; size should be Py_ssize_t, throughout the patch. Other than that, looks pretty mechanical, and I didn't spot anything obviously wrong.
ACK and pushed.
thanks.