Re: [libvirt PATCH] qemu: Fix memstat for (non-)transitional memballoon
On Tue, Jan 12, 2021 at 19:56:11 +0100, Peter Krempa wrote:
On Tue, Jan 12, 2021 at 18:47:36 +0100, Andrea Bolognani wrote:
> Depending on the memballoon model, the corresponding QOM node
> will have a different type and we need to account for this
> when searching for it in the QOM tree.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1911786
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> src/qemu/qemu_monitor.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
[...]
> + case VIR_DOMAIN_MEMBALLOON_MODEL_LAST:
> + default:
> + virReportEnumRangeError(virDomainMemballoonModel,
> + balloon->model);
> + return;
[...]
Also, reporting errors in a function which doesn't abort
execution on
said error is dubious.
Disregard this. Multiple places in this function have this dubious error
reporting.