On 8/20/19 11:30 AM, Michal Privoznik wrote:
The KVM style of PCI assignment is not used, and it hasn't been for a while. Any attempt to start a domain with it would result in error as kernel dropped its support in 4.12.0 (after being deprecated for 1.5 years).
LGTM. Just a comment in patch 01. After applying the whole series I tried to find the remaining references of 'pci-assign'. This is what git grep returns: $ git grep 'pci-assign' src/qemu/qemu_capabilities.h: X_QEMU_CAPS_PCI_CONFIGFD, /* pci-assign.configfd */ src/qemu/qemu_capabilities.h: X_QEMU_CAPS_PCI_BOOTINDEX, /* pci-assign.bootindex */ tests/qemucapabilitiesdata/caps_1.5.3.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_1.6.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_1.7.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.1.1.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.10.0.x86_64.replies: "name": "kvm-pci-assign", tests/qemucapabilitiesdata/caps_2.4.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.5.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.6.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.7.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.8.0.x86_64.replies: "name": "kvm-pci-assign" tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies: "name": "kvm-pci-assign" And with 'configfd': $ git grep 'configfd' docs/news-2011.html.in: qemu: simplify PCI configfd handling in monitor (Eric Blake),<br/> src/qemu/qemu_capabilities.c: "pci-configfd", src/qemu/qemu_capabilities.h: X_QEMU_CAPS_PCI_CONFIGFD, /* pci-assign.configfd */ tests/qemustatusxml2xmldata/migration-in-params-in.xml: <flag name='pci-configfd'/> tests/qemustatusxml2xmldata/migration-out-params-in.xml: <flag name='pci-configfd'/> Do we still need X_QEMU_CAPS_PCI_CONFIGFD and X_QEMU_CAPS_PCI_BOOTINDEX after this series? Thanks, DHB
Michal Prívozník (12): qemu: Drop KVM assignment tests: Remove 'kvm' PCI backend from domaincapstest virhostdev: Unify virDomainHostdevDef to virPCIDevice translation qemu: Drop unused qemuOpenPCIConfig() virhostdev: Disable legacy kvm assignment virpci: Drop 'pci-stub' driver virpci: Remove unused virPCIDeviceWaitForCleanup virpci: Drop newid style of PCI device detach virpcimock: Don't create "pci-stub" driver virpcimock: Don't create new_id or remove_id files virpcimock: Drop @driverActions enum news: Document KVM assignment removal
docs/news.xml | 13 + src/libvirt_private.syms | 1 - src/qemu/qemu_capabilities.c | 6 - src/qemu/qemu_command.c | 48 +-- src/qemu/qemu_command.h | 3 - src/qemu/qemu_driver.c | 14 +- src/qemu/qemu_hostdev.c | 44 +- src/qemu/qemu_hostdev.h | 1 - src/qemu/qemu_hotplug.c | 20 +- src/util/virhostdev.c | 97 +++-- src/util/virpci.c | 403 +----------------- src/util/virpci.h | 2 - .../qemu_1.7.0.x86_64.xml | 1 - .../qemu_2.12.0-virt.aarch64.xml | 1 - .../qemu_2.12.0.ppc64.xml | 1 - .../qemu_2.12.0.s390x.xml | 1 - .../qemu_2.12.0.x86_64.xml | 1 - .../qemu_2.6.0-virt.aarch64.xml | 1 - .../qemu_2.6.0.aarch64.xml | 1 - .../domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 - .../qemu_2.6.0.x86_64.xml | 1 - .../domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 - .../qemu_2.8.0-tcg.x86_64.xml | 1 - .../domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 - .../qemu_2.8.0.x86_64.xml | 1 - .../qemu_2.9.0-q35.x86_64.xml | 1 - .../qemu_2.9.0-tcg.x86_64.xml | 1 - .../qemu_2.9.0.x86_64.xml | 1 - .../domaincapsschemadata/qemu_3.0.0.s390x.xml | 1 - .../qemu_3.1.0.x86_64.xml | 1 - .../domaincapsschemadata/qemu_4.0.0.s390x.xml | 1 - .../qemu_4.0.0.x86_64.xml | 1 - .../qemu_4.1.0.x86_64.xml | 1 - tests/domaincapstest.c | 4 +- tests/virpcimock.c | 137 +----- 35 files changed, 92 insertions(+), 722 deletions(-)