Re: [libvirt] [PATCH] Fix xend XML generation when CPU pinning is used
On Thu, Jan 29, 2009 at 11:35:19AM +0000, Daniel P. Berrange wrote:
> Fix xend XML generation when CPU pinning is used
>
> Signed-off-by: John Levon <john.levon(a)sun.com>
Am I right in thinking that the problem addressed here, is that if
the SEXPR has CPU pinning data, we'd be parsing it into a NULL
'cpumask' field and thus crashing ? If so, ACK to this. Be good
to add a test datafile for this too
Not quite: if cpumask is NULL, then virDomainCpuSetParse() returns with
failure, so you got:
# virsh dumpxml domu-220
libvir: error : Unknown failure
Will add a test case.
regards
john