Re: [libvirt] [qemu RFC v3 1/3] qapi: add SysEmuTarget to "common.json"
On Sat, Apr 21, 2018 at 01:12:44AM +0200, Laszlo Ersek wrote:
We'll soon need an enumeration type that lists all the softmmu
targets
that QEMU (the project) supports. Introduce @SysEmuTarget to
"common.json".
[...]
Notes:
RFCv3:
- The patch is new in this version. [Dan, Markus]
- The original idea was to call the new enum @Target; however, @Target
generates exactly the TARGET_AARCH64, TARGET_ALPHA, TARGET_ARM, ...
enumeration constants that conflict with the poisoned preprocessing
macros of the same names. Hence @SysEmuTarget -- it's more accurate
anyway, since we want it to stand for system emulation targets.
- Also, we discussed defining the new type in either "common.json" or
"misc.json". "misc.json" turned out to be a problem:
"firmware.json"
would then include "misc.json" for the new type's sake, but that
inclusion would become the first appearance of "misc.json" -- within
"firmware.json". That messed up the generated documentation. By adding
the new type to "common.json", "misc.json" (see the 2nd patch)
and
"firmware.json" (see the 3rd patch) can both consume the new type
without problems.
The last two points are interesting enough (for me) to still to keep in
the commit message, but that's minor :-)
qapi/common.json | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
FWIW:
Reviewed-by: Kashyap Chamarthy <kchamart(a)redhat.com>
[...]
--
/kashyap