"Daniel P. Berrange" <berrange@redhat.com> wrote:
On Tue, Feb 26, 2008 at 03:38:56PM +0100, Jim Meyering wrote:
diff --git a/src/qemu_driver.c b/src/qemu_driver.c index f97ef18..d9a7aca 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1315,8 +1315,9 @@ static void qemudDispatchVMEvent(int fd, int events, void *opaque) { qemudDispatchVMFailure(driver, vm, fd); }
-static int qemudMonitorCommand(struct qemud_driver *driver ATTRIBUTE_UNUSED, - struct qemud_vm *vm, +static int qemudMonitorCommand(const struct qemud_driver *driver + ATTRIBUTE_UNUSED, + const struct qemud_vm *vm,
I don't like having annotations for a param on a separate line, because it doesn't read naturally. If we really need to wrap this, then lets follow the style of putting the return type on a line before , eg
static int qemudMonitorCommand(const struct qemud_driver *driver ATTRIBUTE_UNUSED, const struct qemud_vm *vm,
Good idea. I prefer that anyhow, because it's what I'm used to and since some naive start-of-function-finding tools work better that way.
If it is still over 80 characters with this convention, then so be it.