On Fri, Jul 07, 2006 at 04:55:49PM +0100, Daniel P. Berrange wrote:
On Fri, Jul 07, 2006 at 11:46:08AM -0400, Daniel Veillard wrote:
in xenDaemonLookupByID, it seems (but I may have misread the patch) that the free of name in the error code in case the rpc failed is a bit risky and should be guarded by if (name != NULL)
Yep, good catch - I missed that check.
okay :-)
and the documentation for the new function in xend_internal.h is the old one inherited from Anthony first version, I somehow deprecated it, documenting the function itself in the .c file, but it's just nitpicking :-)
Ok, since its all duplicated in the .c file, shall we just rip out all the docs from the xend_internal.h files ?
Hum, maybe as a separate commit ... Actually I used that as a way to remember the old set of functions that I may remove from xend_internal.[ch] if we don't end up using them :-) its not pretty but it's useful ... Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/